chore(Android): Migrate DebugOverlayTag and ReactDebugOverlayTag to Kotlin#47362
Closed
TheRogue76 wants to merge 2 commits into
Closed
chore(Android): Migrate DebugOverlayTag and ReactDebugOverlayTag to Kotlin#47362TheRogue76 wants to merge 2 commits into
TheRogue76 wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 4da586e. |
Collaborator
|
This pull request was successfully merged by @TheRogue76 in 4da586e When will my fix make it into a release? | How to file a pick request? |
Contributor
|
@TheRogue76 thank you very much for sending this over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I believe these two were the last items under
com.facebook.debugthat were still Java.I thought about making DebugOverlayTag a Data class, but i will leave it up to the reviewer to decide if it would be needed or not.
Changelog:
[INTERNAL] [FIXED] - Migrate DebugOverlayTag and ReactDebugOverlayTag to Kotlin
Test Plan:
./gradlew test: